Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js #50785

Merged
merged 1 commit into from
Dec 1, 2023
Merged

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js #50785

merged 1 commit into from
Dec 1, 2023

Conversation

aparzi
Copy link
Contributor

@aparzi aparzi commented Nov 18, 2023

fix for loop

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
RafaelGSS
RafaelGSS requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow our commit guidelines? You might want to squash all the commits too.

@aparzi
Copy link
Contributor Author

aparzi commented Nov 24, 2023

Hi @RafaelGSS,
Could you tell me what and how to fix? Thank you

@RafaelGSS
Copy link
Member

Try the following:

git rebase -i HEAD~3

Go to your first commit and change pick to edit, the other two commits you use squash, then it will open a editor to edit the first commit, so you follow our commit guidelines, in this case changing the commit to:

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js

@aparzi
Copy link
Contributor Author

aparzi commented Nov 24, 2023

Hi @RafaelGSS,
I collapsed everything into one commit

RafaelGSS
RafaelGSS reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aparzi If you look at the commit list, the author doesn't seem your github handle (@aparzi)

Also, the commit length oversizes our commit guideline. See https://github.com/nodejs/node/actions/runs/6982553346/job/19058853209?pr=50785

@aparzi
Copy link
Contributor Author

aparzi commented Nov 27, 2023

Hi @RafaelGSS, could you check now?

@aparzi
Copy link
Contributor Author

aparzi commented Nov 28, 2023

Hi @RafaelGSS, any news for this PR? Thanks

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56013/

@RafaelGSS RafaelGSS changed the title fix for loop test: replace forEach to for.. test-webcrypto-export-import-cfrg.js Dec 1, 2023
@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 60ffa9f into nodejs:main Dec 1, 2023
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 60ffa9f

targos pushed a commit that referenced this pull request Dec 4, 2023
@aparzi @targos
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
3a1c664 
PR-URL: #50785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@targos targos mentioned this pull request Dec 4, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aparzi @richardlau
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
1c28db8 
PR-URL: #50785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aparzi @RafaelGSS @nodejs-github-bot @jasnell @marco-ippolito